Skip to content

Fixed crash in RN 0.78.x #2624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed crash in RN 0.78.x #2624

wants to merge 1 commit into from
+7 −7

Conversation

bmatasar
Copy link
Contributor

It seems prevProps and this.props are always different in RN 0.78.

Compare only the properties used in the update of the reservation list.

@bmatasar
Fixed crash in RN 0.78.x
813f338 
It seems `prevProps` and `this.props` are always different in RN 0.78.
Compare only the properties used in the  update of the reservation list
@bmatasar
Copy link
Contributor Author

This is a fix for #2610

@bmatasar bmatasar mentioned this pull request Mar 25, 2025
Open
@diegomichell
Copy link

I reviewed and tested the changes, this does fix the problem. 💯

@kevindaviladev
Copy link

I test this locally and works! awesome @bmatasar

@kervyntan
Copy link

Can someone help to merge this in? I need it urgently for prod

@simnik12
Copy link

simnik12 commented Jun 5, 2025

This patch works for me

@maukoese
Copy link

Anyone to approve this? Please?

@shareef-dweikat
Copy link

I’ve tried it. The Agenda is no longer crashing.

@shareef-dweikat shareef-dweikat mentioned this pull request Jun 14, 2025
Open
@fabrianibrahim
Copy link

fabrianibrahim commented Sep 22, 2025 •
edited
Loading

can this urgent fix be merged? we need reviewers with write access @bmatasar

@bmatasar
Copy link
Contributor Author

can this urgent fix be merged? we need reviewers with write access @bmatasar

Sorry, I don't have write access. I have just contributed with the fix and I don't know why it's been pending for such a long time.
If you use patch-package, you could also add the attached patch to the project until they approve this fix or an alternate one.
react-native-calendars+1.1313.0.patch

@fabrianibrahim
Copy link

hi @Inbal-Tish , can we please merge and release this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
3 more reviewers

@shareef-dweikat shareef-dweikat shareef-dweikat approved these changes

@tascott tascott tascott approved these changes

@oozd oozd oozd approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@bmatasar @diegomichell @kevindaviladev @kervyntan @simnik12 @maukoese @shareef-dweikat @fabrianibrahim @tascott @oozd